Bug 705181: Fix annoying beeping introduced by Mac IME

NSTextInputClient should not chain unhandled commands to super

(cherry picked from commit 91bcca6f395ba6d5aa5a688d6d629633bbea539f)

diff --git a/gdk/quartz/GdkQuartzView.c b/gdk/quartz/GdkQuartzView.c
index 0254ee319edabf18e7ae4a6c43007a5d43b6aed9..6bc3afeea176e008bba89b810604c2f8718f506b 100644 (file)
--- a/gdk/quartz/GdkQuartzView.c
+++ b/gdk/quartz/GdkQuartzView.c
@@ -172,7 +172,11 @@
 -(void)doCommandBySelector: (SEL)aSelector
 {
   GDK_NOTE (EVENTS, g_print ("doCommandBySelector\n"));
-  [super doCommandBySelector: aSelector];
+  /* Do nothing. Although we are required to implement this method for
+   * NSTextInputClient, we do not handle Cocoa command IDs, and the
+   * Apple docs explicitly say not to forward unhandled commands up
+   * the NSReponder chain, which calls NSBeep().
+  */
 }
 
 -(void)insertText: (id)aString replacementRange: (NSRange)replacementRange